Add vertical tray layout toggle#648
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughThis PR adds a persisted trayLayout preference, a HUD toggle to switch horizontal/vertical layouts, conditional styling across HUD sections, and localized tooltip strings in 12 locales. ChangesVertical Tray Layout Toggle with Persistence
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint skipped: no ESLint configuration detected in root package.json. To enable, add Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
src/i18n/locales/zh-TW/launch.json (1)
11-12: ⚡ Quick winterminology drift across locales – might wanna unify
so i noticed the translations use different concepts for "tray" across languages:
- ja-JP, ko-KR, vi, zh-CN: "tray" (トレイ, 트레이, khay, 托盘)
- ru: "panel" (панель)
- tr, zh-TW: "toolbar" (araç çubuğunu, 工具列)
lowkey inconsistent, especially zh-CN (托盘 = tray) vs zh-TW (工具列 = toolbar) since those should typically align for UI elements. could be intentional localization choices but worth verifying with native speakers that these all convey the same UI concept.
not blocking since translations are functional, just might confuse multilingual users or make docs harder to maintain.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/i18n/locales/zh-TW/launch.json` around lines 11 - 12, The locale strings for useVerticalTray and useHorizontalTray use inconsistent terminology across locales (e.g., zh-TW uses "工具列" while zh-CN uses "托盘"); update the translations for the keys useVerticalTray and useHorizontalTray to use a consistent term across all locales (pick the correct UI term—"tray" vs "toolbar"), verify the chosen term with native speakers for each language (especially zh-TW vs zh-CN), and then replace the differing strings in the affected locale files so all locales convey the same UI concept for these keys.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@src/i18n/locales/zh-TW/launch.json`:
- Around line 11-12: The locale strings for useVerticalTray and
useHorizontalTray use inconsistent terminology across locales (e.g., zh-TW uses
"工具列" while zh-CN uses "托盘"); update the translations for the keys
useVerticalTray and useHorizontalTray to use a consistent term across all
locales (pick the correct UI term—"tray" vs "toolbar"), verify the chosen term
with native speakers for each language (especially zh-TW vs zh-CN), and then
replace the differing strings in the affected locale files so all locales convey
the same UI concept for these keys.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 8244e14d-2556-4601-aaf5-4406b07454f0
📒 Files selected for processing (15)
src/components/launch/LaunchWindow.tsxsrc/i18n/locales/ar/launch.jsonsrc/i18n/locales/en/launch.jsonsrc/i18n/locales/es/launch.jsonsrc/i18n/locales/fr/launch.jsonsrc/i18n/locales/it/launch.jsonsrc/i18n/locales/ja-JP/launch.jsonsrc/i18n/locales/ko-KR/launch.jsonsrc/i18n/locales/ru/launch.jsonsrc/i18n/locales/tr/launch.jsonsrc/i18n/locales/vi/launch.jsonsrc/i18n/locales/zh-CN/launch.jsonsrc/i18n/locales/zh-TW/launch.jsonsrc/lib/userPreferences.test.tssrc/lib/userPreferences.ts
Summary
Why
This gives users a vertical tray option for presentation, screen sharing, and different monitor layouts while keeping the existing horizontal tray as the default.
Tests
npm testnpm run lintnpm run build-vitehttp://127.0.0.1:5173/?windowType=hud-overlay: toggled to vertical layout and confirmed the preference persisted after reload.npm run i18n:checkcurrently fails on an existing unrelated missing key:it/settings.jsonis missingzoom.previewHold.Closes #571
Summary by CodeRabbit
New Features
Documentation
Tests