You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR introduces a recovery mechanism for exported videos when the native save dialog is cancelled. It updates
VideoEditor.tsx
to preserve the rendered video buffer in state and adds a "Choose Save Location" button to
SettingsPanel.tsx
to let users trigger the save dialog again without re-rendering.
Motivation
Currently, if a user exports a video or GIF and accidentally cancels the operating system's save dialog, the rendered buffer is immediately discarded. This forces the user to sit through the entire CPU-intensive rendering process over again just to save the file. This change improves the UX by keeping the buffer in memory so the file can be saved instantly when the user is ready.
Type of Change
Bug Fix (fixes unintentional data loss of the rendered buffer upon dialog cancellation).
Related Issue(s)
No related issue.
Screenshots / Video
Screenshot (if applicable):
Video (if applicable):
NONE
Testing
Exported a video and intentionally cancelled the native OS save dialog.
Verified that the new "Choose Save Location" button correctly appeared in the settings panel.
Clicked the button and verified the save dialog reappeared.
Saved the file and confirmed it wrote to disk successfully without triggering a re-render.
Verified the recovery state appropriately clears on a successful save and when starting a fresh export.
Verified TypeScript compilation passes locally.
Can you rebase on top of main (new PR checks before merge can go in, and also resolve the conflicts?) I'd like this to go in the next release.
On it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
This PR introduces a recovery mechanism for exported videos when the native save dialog is cancelled. It updates
VideoEditor.tsx
to preserve the rendered video buffer in state and adds a "Choose Save Location" button to
SettingsPanel.tsx
to let users trigger the save dialog again without re-rendering.
Motivation
Currently, if a user exports a video or GIF and accidentally cancels the operating system's save dialog, the rendered buffer is immediately discarded. This forces the user to sit through the entire CPU-intensive rendering process over again just to save the file. This change improves the UX by keeping the buffer in memory so the file can be saved instantly when the user is ready.
Type of Change
Bug Fix (fixes unintentional data loss of the rendered buffer upon dialog cancellation).
Related Issue(s)
No related issue.
Screenshots / Video
Screenshot (if applicable):
Video (if applicable):
NONE
Testing
Exported a video and intentionally cancelled the native OS save dialog.
Verified that the new "Choose Save Location" button correctly appeared in the settings panel.
Clicked the button and verified the save dialog reappeared.
Saved the file and confirmed it wrote to disk successfully without triggering a re-render.
Verified the recovery state appropriately clears on a successful save and when starting a fresh export.
Verified TypeScript compilation passes locally.
Checklist
Thank you for contributing!