Added keyboard shortcuts to the video editor#178
Open
KoopaCode wants to merge 5 commits intosiddharthvaddem:mainfrom
Open
Added keyboard shortcuts to the video editor#178KoopaCode wants to merge 5 commits intosiddharthvaddem:mainfrom
KoopaCode wants to merge 5 commits intosiddharthvaddem:mainfrom
Conversation
8 tasks
Contributor
|
Hey, thanks for your work ! A configurable keyboard shortcuts system #172 will be soon merged into main, if you want, you can already adapt your PR to this new feature. |
Owner
|
#172 has been merged. If you can adapt your PR to sync with these new changes, that would be great 🙏 |
Owner
|
Actually I think these would be fixed anyways, spacebar toggle is the de facto pause/play and left right keys make sense for moving as well. I think this should be good to merge once you resolve the conflicts. |
|
please also add del key for deleting the selected element |
|
also, the undo and redo dont work as they add a zoom instead pressing the Z key |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Added keyboard shortcuts to the video editor: spacebar toggles play/pause, left/right arrow keys seek ±1 second.
Motivation
Allows faster and more video navigation using the keyboard.
Type of Change
Related Issue(s)
N/A
Screenshots / Video
Video (if applicable):
https://i.nulz.host/vgLCH8Rkrq.gif
Testing
Checklist
Thank you for contributing!