Propagate HTTP status code in structured HTTPError type#126
Open
jml wants to merge 1 commit intoshurcooL:mainfrom
Open
Propagate HTTP status code in structured HTTPError type#126jml wants to merge 1 commit intoshurcooL:mainfrom
jml wants to merge 1 commit intoshurcooL:mainfrom
Conversation
Callers often need to distinguish between different HTTP error codes (e.g. 401 vs 500) to decide how to handle failures. Previously the status code was embedded in an opaque error string. Introduce an exported HTTPError type with StatusCode and Body fields. The Error() string is unchanged, so existing callers are unaffected. New callers can use errors.As to extract the structured fields. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Author
|
Thanks! What happens next? |
|
I'm a random Gopher who follows the repository. Let's wait for a maintainer to review it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
I've been wanting to get better metrics on our GraphQL calls, especially through https://github.com/shurcooL/githubv4. Rather than parsing out the error string, I thought it would be better to make a structured error.
The
Error()string is intentionally unchanged from the previousfmt.Errorfoutput, so existing callers matching onerr.Error()orerr != nilare unaffected. The only behavioral change is that the concrete type is nowHTTPErrorrather than*fmt.wrapError, which matters only for callers using type assertions (who would benefit from the change).Similar to #68, but focusing on errors only.