Open
Conversation
The API URI is changed, so the old method to fetch rate from the api is not working, this is a solution for the problem, all country rates converting with the updated base URI and the rate value set to let rate = fromData[fromCurr.value.toLowerCase()][toCurr.value.toLowerCase()]
|
The API isn't working anymore. Use the Frankfurter API-- https://api.frankfurter.dev/v1/latest |
UjjwalVaidya
left a comment
UjjwalVaidya
left a comment
There was a problem hiding this comment.
Great work on this change! This is a solid improvement over the previous implementation.
|
error on app.js file |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The API URI is changed, so the old method to fetch rate from the api is not working, this is a solution for the problem, all country rates converting with the updated base URI and the rate value set to let rate = fromData[fromCurr.value.toLowerCase()][toCurr.value.toLowerCase()]