Open
Conversation
6 tasks
ihor-bobyr
force-pushed
the
20-create-sign-upanketa-page
branch
from
4f1eddf to
17c24a5
Compare
k-boiko
reviewed
May 11, 2024
| @@ -0,0 +1,14 @@ | |||
| export const PageProxy = { | |||
| redirectToAdults() { | |||
| location.href += '/adults'; | |||
Collaborator
There was a problem hiding this comment.
here might be some problems if we want to reuse this class for form on adults landing page, which has url /courses/adults, so I'd suggest setting full path here, instead of adding.
ihor-bobyr
force-pushed
the
20-create-sign-upanketa-page
branch
from
17c24a5 to
44c491b
Compare
k-boiko
reviewed
May 19, 2024
| set data({ name, surname, birthday }) { | ||
| getInputRef('name').value = name; | ||
| getInputRef('surname').value = surname; | ||
| getInputRef('birthday').value = birthday; |
Collaborator
There was a problem hiding this comment.
This line overrides the default value from input provided in HTML, can you please check here for the birthday variable not to have empty value?
k-boiko
reviewed
May 19, 2024
| currentDate.getMonth(), | ||
| currentDate.getDate(), | ||
| ]; | ||
| const [birthYear, birthMonth, birthDay] = birthDate.split('-').map((item) => +item); |
Collaborator
There was a problem hiding this comment.
There might be risk at some moment for the format of this value to be changed, so I'd suggest using Date constructor instead and calling methods getFullYear etc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.