Skip to content

SG-41264 Fixup exception instance don't all have a message attribute #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
julien-lang wants to merge 3 commits into
base: master
Choose a base branch
from
Open

SG-41264 Fixup exception instance don't all have a message attribute #306

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
52633eb
Fixup exception instance don't all have a message attribute
julien-lang Nov 25, 2025
74867da
Update python/tk_framework_desktopserver/shotgun/api_v2.py
julien-lang Nov 25, 2025
82c2c56
Merge remote-tracking branch 'origin/master' into ticket/SG-41264
julien-lang Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion python/tk_framework_desktopserver/shotgun/api_v2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -772,7 +772,12 @@ def open(self, data):
self.host.reply(reply)
except Exception as e:
logger.exception(e)
self.host.report_error(e.message)
Copy link
Copy Markdown
Contributor

@carlos-villavicencio-adsk carlos-villavicencio-adsk Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the exception object should have the __str__ method defined so probably it's enough with this?

self.host.report_error(str(e))

if hasattr(e, "message"):
self.host.report_error(e.message)
elif e.args:
self.host.report_error(str(e.args[0]))
else:
self.host.report_error("unknown error")
Comment thread
julien-lang marked this conversation as resolved.

def pick_file_or_directory(self, data):
"""
Expand Down
Loading