Skip to content
This repository was archived by the owner on Nov 20, 2023. It is now read-only.

Conversation

@j0yu
Copy link

@j0yu j0yu commented Jun 4, 2019

Changes from v1.0.0+wwfx.0.2.0 to v1.0.0+wwfx.0.3.0

Functional improvements and fixes from testing tk-doc-generator (locally using preview_docs.sh and on travis.ci) with tk-katana on the ci-docs branch/PR. See also tk-katana's gh-pages

  • Dockerfile:

    • Moved Gem* from /app to /usr/local/src.
      • Keeps /app clean for docker run.
    • Added default ENTRYPOINT to run build_docs.sh.
    • Added tk-core as Sphinx conf.py requires it.
    • Optimised yum install packages, Ruby curl/untar.
    • Using nproc, replacing hard-coded jobs count.
  • preview_docs.sh:

    • Support -v instead of --mount for docker run when using older docker version shipped with CentOS 7.
    • Will not re-build Docker image if tk-doc-generator image exists.
      • Force rebuild using preview_docs.sh --rebuild.
    • Can now be run anywhere, including within tk-doc-generator
  • build_docs.sh:

    • Fixed configurations using absolute paths.
    • Fixed inaccurate echo statements
  • Gemfile*: Using WWFX just-the-docs with new external links test

    • May want to change these Gemfile* if the PR gets merged

@j0yu j0yu force-pushed the dockerfile-fixes-default-run-sg branch from 4d0fccc to 8012fc9 Compare June 4, 2019 17:34
@j0yu j0yu force-pushed the dockerfile-fixes-default-run-sg branch from 8012fc9 to 2df5344 Compare June 7, 2019 13:38
@j0yu j0yu mentioned this pull request Jun 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant