Make midi_mappings also cover MIDI note-on events.#694
Open
Conversation
Collaborator
Author
|
WARNING: This modification removes the setting of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This takes the midi mapping structure built to automatically convert MIDI Control Change messages into wire commands, and extends it to work for MIDI note-on message. By default, MIDI note-on messages have the mapping
-1,0,0,1,0,i%in%nl%v, meaning that any note is converted to a note-on command for the matching synth. But this command can be overridden e.g.amy.send(synth=1, midi_note_cmd='-1,0,0,1,0,i%in%nl%vZ-1,0,0,1,0,i2n%nl%v')would convert any MIDI note-on command on channel 1 to two internal note-ons, one to synth 1, and a simultaneous one to synth 2.