Skip to content

avoid adding ParticleNuclideFilter multiple times to tally in prepare_tallies #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shimwell wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

avoid adding ParticleNuclideFilter multiple times to tally in prepare_tallies #75

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
171cf85
added-check-for-parnucfilter
shimwell Jul 18, 2025
b48342c
added test for parnucfil addition
shimwell Jul 18, 2025
c8d19d3
Simplify logic
paulromano Jul 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions openmc/deplete/d1s.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,7 @@ def prepare_tallies(
for f in tally.filters:
if isinstance(f, openmc.ParticleFilter):
if list(f.bins) == ['photon']:
tally.filters.append(filter)
if not tally.contains_filter(openmc.ParentNuclideFilter):
tally.filters.append(filter)
break

return nuclides
5 changes: 5 additions & 0 deletions tests/unit_tests/test_d1s.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,11 @@ def test_prepare_tallies(model):
assert tally.contains_filter(openmc.ParentNuclideFilter)
assert sorted(tally.filters[-1].bins) == sorted(radionuclides)

assert len(tally.filters) == 2
# calling prepare_tallies twice should not add another ParentNuclideFilter
d1s.prepare_tallies(model, chain_file=CHAIN_PATH)
assert len(tally.filters) == 2


def test_apply_time_correction(run_in_tmpdir):
# Make simple sphere model with elemental Ni
Expand Down