Skip to content

Wheel building with ci wheel builder#62

Open
shimwell wants to merge 37 commits intodevelopfrom
wheel_building_without_cython
Open

Wheel building with ci wheel builder#62
shimwell wants to merge 37 commits intodevelopfrom
wheel_building_without_cython

Conversation

@shimwell
Copy link
Owner

@shimwell shimwell commented Aug 13, 2024 •
edited by jon-proximafusion
Loading

this PR is experimenting with the CI wheel builder approach to making wheels

shimwell and others added 29 commits July 19, 2024 01:25
@shimwell
draft scikit build core wheel
e9101ab
@shimwell
renamed executable
e857f45
@jon-proximafusion
linking libopenmc with openmc in cmakelists
61b7035
@jon-proximafusion
Merge branch 'scikit_build_core_wheel' of github.com:shimwell/openmc …
12cb43d 
…into scikit_build_core_wheel
@jon-proximafusion
updated docs for pip install that compiles
2541d50
@jon-proximafusion
pip install with cmake args in ci
f15e80f
@jon-proximafusion
added missing ,
3c98d8a
@jon-proximafusion
no need for manual creation of build dir
0aafd44
@shimwell
[skip ci] merged develop
12b4221
@shimwell
[skip ci] adding apt packages for read the docs
9ef3beb
@shimwell
[skip ci] trying ubuntu 22.04
40ceaad
@shimwell
[skip ci] added missing s
2c8cf71
@shimwell
adding gha actions
4c0075f
@shimwell
upper case ON for cmake args
4de0d94
@shimwell
added quotes to cmake args
688d688
@shimwell
keeping same filename
07a4dcd
@shimwell
running just pytest
9253977
@shimwell
[skip ci] corrected cmake arg passing example
1f01694
@shimwell
added diagnosis prints
6850217
@shimwell
Merge branch 'scikit_build_core_wheel' of github.com:shimwell/openmc …
a601de8 
…into scikit_build_core_wheel
@shimwell
removed 2nd pip install which was overwritting
97a3f22
@shimwell
float_endf from endf package
41d28ff
@shimwell
removed reference to float endf
c03a236
@jon-proximafusion
removing resonance
3cc88a0
@jon-proximafusion
no longer calling ResonancesWithBackground
f8f9ac4
@shimwell
Merge pull request #59 from shimwell/scikit_build_core_wheel
1912b6c 
Scikit build core wheel
@shimwell
Merge branch 'wheel_building_without_cython' into replacing_endf_c_fu…
d3efb24 
…nctions_with_package
@shimwell
Merge pull request #60 from shimwell/replacing_endf_c_functions_with_…
3c8fb17 
…package

Replacing endf c functions with package
@shimwell
Merge pull request #61 from shimwell/removing_reconstruct_resonance_c…
0731b75 
…ython5

Removing reconstruct resonance cython5
shimwell
shimwell commented Aug 13, 2024
View reviewed changes
@jon-proximafusion
Copy link
Collaborator

jon-proximafusion commented Aug 13, 2024 •
edited
Loading

@ahnaf-tahmid-chowdhury this PR combines three PRs
openmc-dev#3111
openmc-dev#3087
openmc-dev#3101

and extends the code to make use of CI wheel builder action

currently build wheels action is failing with this error message
ValueError: Cannot repair wheel, because required library "libopenmc.so" could not be located

@ahnaf-tahmid-chowdhury
Copy link
Collaborator

ahnaf-tahmid-chowdhury commented Aug 14, 2024

Oh, I know that issue. It happens because libopenmc is not available on the path. However, in this approach, openmc library will be available on the openmc.libs folder which is not a recommended path for the core library. I can come up with the numpy method to install the core library in openmc/core/lib folder. And setup rpath there.

@shimwell
Copy link
Owner Author

shimwell commented Aug 14, 2024

That would be great many thanks for taking a look.

@shimwell shimwell changed the title Wheel building without cython Wheel building with ci wheel builder Aug 14, 2024
@shimwell
Copy link
Owner Author

shimwell commented Aug 14, 2024

PRs openmc-dev#3111 and openmc-dev#3101 have now been merged. So this branch just builds on top of this single PR now openmc-dev#3087

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shimwell @jon-proximafusion @ahnaf-tahmid-chowdhury