Skip to content

added library arg for dose#46

Open
shimwell wants to merge 11 commits intodevelopfrom
allowing_other_dose_coefficients
Open

added library arg for dose#46
shimwell wants to merge 11 commits intodevelopfrom
allowing_other_dose_coefficients

Conversation

@shimwell
Copy link
Owner

@shimwell shimwell commented Oct 25, 2023

Description

This PR allows us to add additional dose conversion libraries. We can add others in the future but for now I've included icrp 119 neutron data which is on page 123 of this report

The ICRP 119 compared to the ICRP 116 is a slightly different, here is a plot for your interest

tagging @rlbarker for your interest

Fixes # (issue)
openmc-dev#2516

Checklist

  • I have performed a self-review of my own code
  • I have run clang-format (version 15) on any C++ source files (if applicable)
  • I have followed the style guidelines for Python source files (if applicable)
  • I have made corresponding changes to the documentation (if applicable)

relying on existing tests in tests/unit_tests/data_dose_coefficients.py

@coveralls
Copy link

Pull Request Test Coverage Report for Build 9084972507

Details

  • 21 of 22 (95.45%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.003%) to 84.646%

Changes Missing Coverage Covered Lines Changed/Added Lines %
openmc/data/effective_dose/dose.py 18 19 94.74%
Totals Coverage Status
Change from base Build 9000100146: -0.003%
Covered Lines: 48465
Relevant Lines: 57256

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants