only package executable and library into wheel#24
Open
hassec wants to merge 1 commit intoshimwell:building_wheels_2from
Open
only package executable and library into wheel#24hassec wants to merge 1 commit intoshimwell:building_wheels_2from
hassec wants to merge 1 commit intoshimwell:building_wheels_2from
Conversation
hassec
commented
Dec 19, 2022
| # Ensure we only bundle what is really needed in the python package. | ||
| # For more info See skbuild docs. | ||
| def filter_install_files(cmake_manifest): | ||
| return list(filter(lambda f: f.endswith(".so") or f.endswith("bin/openmc"), cmake_manifest)) |
Author
There was a problem hiding this comment.
currently just trying to get linux to properly work.
But, note to self that this needs to be extended to work on mac
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Locally, I can build linux wheels with this config, and have the
openmcbinary andlibopenmc.solibrary correctly packaged into the wheel.Something I've not yet had any luck with is editable builds. But they also seem to be somewhat broken in sckit-build + setuptools > 64 (scikit-build/scikit-build#740)
Bit tough to really figure out what the proper way is given the limited scikit-build docs :/