-
Notifications
You must be signed in to change notification settings - Fork 0
Allow to add member to vault. #320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dkocher
wants to merge
1
commit into
main
Choose a base branch
from
issues/311
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
84 changes: 84 additions & 0 deletions
84
hub/src/main/java/cloud/katta/protocols/hub/HubVaultShareFeature.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,84 @@ | ||
| /* | ||
| * Copyright (c) 2026 shift7 GmbH. All rights reserved. | ||
| */ | ||
|
|
||
| package cloud.katta.protocols.hub; | ||
|
|
||
| import ch.cyberduck.core.DescriptiveUrl; | ||
| import ch.cyberduck.core.PasswordCallback; | ||
| import ch.cyberduck.core.Path; | ||
| import ch.cyberduck.core.exception.BackgroundException; | ||
| import ch.cyberduck.core.features.Share; | ||
|
|
||
| import java.util.Collections; | ||
| import java.util.LinkedHashSet; | ||
| import java.util.Set; | ||
| import java.util.UUID; | ||
|
|
||
| import cloud.katta.client.ApiException; | ||
| import cloud.katta.client.api.AuthorityResourceApi; | ||
| import cloud.katta.client.api.VaultResourceApi; | ||
| import cloud.katta.client.model.AuthorityDto; | ||
| import cloud.katta.client.model.Role; | ||
| import cloud.katta.client.model.UserDto; | ||
| import cloud.katta.protocols.hub.exceptions.HubExceptionMappingService; | ||
|
|
||
| public class HubVaultShareFeature implements Share<Void, Void> { | ||
|
|
||
| private final HubSession session; | ||
|
|
||
| public HubVaultShareFeature(final HubSession session) { | ||
| this.session = session; | ||
| } | ||
|
|
||
| @Override | ||
| public boolean isSupported(final Path file, final Type type) { | ||
| switch(type) { | ||
| case download: | ||
| // Only when owner | ||
| if(file.isDirectory()) { | ||
| return file.getParent().isRoot(); | ||
| } | ||
| } | ||
| return false; | ||
| } | ||
|
|
||
| @Override | ||
| public Set<Sharee> getSharees(final Type type) throws BackgroundException { | ||
| try { | ||
| switch(type) { | ||
| case download: | ||
| final Set<Sharee> users = new LinkedHashSet<>(); | ||
| for(AuthorityDto authority : new AuthorityResourceApi(session.getClient()).apiAuthoritiesSearchGet("%", false)) { | ||
| final Object instance = authority.getActualInstanceRecursively(); | ||
| if(instance instanceof UserDto) { | ||
| final UserDto user = (UserDto) instance; | ||
| users.add(new Sharee(user.getId(), String.format("%s (%s)", user.getName(), user.getEmail()))); | ||
| } | ||
| } | ||
| return users; | ||
| } | ||
| return Collections.emptySet(); | ||
| } | ||
| catch(ApiException e) { | ||
| throw new HubExceptionMappingService().map(e); | ||
| } | ||
| } | ||
|
|
||
| @Override | ||
| public DescriptiveUrl toDownloadUrl(final Path file, final Sharee sharee, final Void options, final PasswordCallback callback) throws BackgroundException { | ||
| try { | ||
| new VaultResourceApi(session.getClient()).apiVaultsVaultIdUsersUserIdPut(sharee.getIdentifier(), | ||
| UUID.fromString(file.attributes().getFileId()), Role.MEMBER); | ||
| return DescriptiveUrl.EMPTY; | ||
| } | ||
| catch(ApiException e) { | ||
| throw new HubExceptionMappingService().map(e); | ||
| } | ||
| } | ||
|
|
||
| @Override | ||
| public DescriptiveUrl toUploadUrl(final Path file, final Sharee sharee, final Void options, final PasswordCallback callback) throws BackgroundException { | ||
| return DescriptiveUrl.EMPTY; | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a TODO or how do we ensure ownership?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chenkins What API can be used to determine the user role?