Fix Agent::__call signature for mobiledetectlib 4.10 compatibility#77
Open
refringe wants to merge 1 commit into
Open
Fix Agent::__call signature for mobiledetectlib 4.10 compatibility#77refringe wants to merge 1 commit into
refringe wants to merge 1 commit into
Conversation
mobiledetect/mobiledetectlib 4.10.0 added typed parameter and return type declarations to MobileDetect::__call. Agent's untyped override caused a fatal LSP-incompatibility error at class load time on any install resolving 4.10+. Adopt the typed signature on Agent::__call and bump the mobiledetect/mobiledetectlib constraint to ^4.10 so installs pull a compatible parent. Fixes shetabit#76
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Agent::__callto use the typed signature(string $name, array $arguments): boolso it remains compatible withDetection\MobileDetect::__call, which became typed inmobiledetect/mobiledetectlib4.10.0.mobiledetect/mobiledetectlibconstraint from>=4.8 <4.9to^4.10so installs resolve a parent class whose signature matches the override.Fixes #76.