Fix Parameters:value handling to prevent unmatched braces error#6
Open
coiby wants to merge 1 commit intoshellspec:mainfrom
Open
Fix Parameters:value handling to prevent unmatched braces error#6coiby wants to merge 1 commit intoshellspec:mainfrom
coiby wants to merge 1 commit intoshellspec:mainfrom
Conversation
Resolves: shellspec#5 The Parameters:value construct in shellspec is a standalone declaration that doesn't require wrapping with braces like other DSL constructs. Previously, altshfmt was adding opening braces after Parameters:value lines but no matching closing braces, causing shfmt to fail with "reached EOF without matching { with }". This fix adds special handling for Parameters:value to skip brace wrapping while preserving correct behavior for other Parameters variants (block, matrix, dynamic) that do require braces. Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Coiby Xu <coiby.xu@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #5
The Parameters:value construct in shellspec is a standalone declaration that doesn't require wrapping with braces like other DSL constructs. Previously, altshfmt was adding opening braces after Parameters:value lines but no matching closing braces, causing shfmt to fail with "reached EOF without matching { with }".
This fix adds special handling for Parameters:value to skip brace wrapping while preserving correct behavior for other Parameters variants (block, matrix, dynamic) that do require braces.