fix use-after-free soundness issues#8
Merged
Conversation
This patch fixes some use-after-free soundness issues that are due to the way that Master and Slave are cloneable. Fortunately, I think the API also not being correctly RAII meant that this wasn't causing crashes (though only because we were leaking resources). I'm beginning to think it was a mistake to use the pty crate. This is a breaking change so I'll need to bump the minor version.
ethanpailes
force-pushed
the
fix-lifetime-soundness
branch
from
6212c23 to
cd578f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch fixes some use-after-free soundness issues that are due to the way that Master and Slave are cloneable. Fortunately, I think the API also not being correctly RAII meant that this wasn't causing crashes (though only because we were leaking resources).
I'm beginning to think it was a mistake to use the pty crate.
This is a breaking change so I'll need to bump the minor version.