Fix false update notice when product_version is not yet set#13
Merged
Conversation
product_version is only populated during the init hook, but pre_set_site_transient_update_plugins can fire earlier (e.g. during plugin activation). With product_version null, version_compare always returns true, showing an update even when the installed version matches. Fall back to the version from $transient->checked and bail out early when no version is available. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
product_versionis only populated during theinithook, butpre_set_site_transient_update_pluginscan fire earlier (e.g. during plugin activation viarefresh_updates_transient/clear_updates_transient)product_versionasnull,version_compare('5.0.0', null, '>')always returnstrue, showing an update available even when the installed version matches the API version$transient->checked(which WordPress populates with installed versions) and bail out early when no version is availableTest plan
🤖 Generated with Claude Code