Use staging endpoint for image assets #114
Open
+94
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OtterleyW
force-pushed
the
use-staging-endpoint
branch
from
6066a0c to
300a395
Compare
OtterleyW
force-pushed
the
use-staging-endpoint
branch
from
300a395 to
a1d5bc5
Compare
rap1ds
approved these changes
Jan 22, 2026
| (.append form-data (str "staging-id-" i) (str staging-id))) | ||
| (when (and (not staging-id) (or data-raw full-path)) | ||
| (when-let [payload (or data-raw | ||
| (when full-path |
| ;; Node's form-data rejects cljs-node-io streams (DelayedStream wrapper) | ||
| ;; so we need to convert assets into Buffers/strings before appending them. | ||
| binary (or data-raw | ||
| (when full-path |
Member
There was a problem hiding this comment.
Why do we need to add this now? Didn't we have file uploading working already without this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement CLI changes to stage asset files before pushing. Currently, our stage API endpoint supports staging only image files. On the CLI side, we skip staging for .json files; for all other asset types, we rely on the API to return an error if the file type is not supported.
(Internal use)