Merging contribution from shpingalet007 to allow arguments #3
Merging contribution from shpingalet007 to allow arguments #3shanegenschaw merged 10 commits intomasterfrom
Conversation
Parsed only when allow_arguments is set
@zeit/ncc is deprecated
9356112 to
524ea24
Compare
|
Looks good 👍 |
|
@shpingalet007 I noticed the |
|
#deploy show me a rocket |
d1babb6 to
bd2d843
Compare
|
test comment |
|
#deploy test |
|
#look |
|
#deploy on ** environment |
|
#deploy test |
Seems like API access error as responds with 403, but no idea why. I'll look into it soon |
|
#look |
|
#deploy test |
|
#deploy on ** environment test |
|
I didn't have the repo setup to allow GitHub Actions to post comments, I've fixed that issue so the access errors are gone. It's really not a blocker IMO since it is just in the example workflow, and shouldn't break the action itself. Just would be nice to not trip up future contributions. |
|
#deploy on dev environment |
|
@shanegenschaw I see... Looks like some unhandled error. The asterisks in the example command are a wildcard for a word. That's why it breaks if we put there **. However, something is wrong here. The command |
|
@shpingalet007 gotcha, user error on my part then 😄 |
|
Okay @shanegenschaw 😀👍 Happy to collaborate on that, it's a pleasure. Anyway, I'll look into that next days and update the mainstream PR. I will let you know to update that on your fork when it would be ready. Have a nice weekend! Update: I have a test repo where I was using this action charged with arguments. I will leave here the link for you if you would like to look for a reference on what can be done with this PR accepted shpingalet007/pr-deployments/pull/1 |
Merging Khan#34.
With contributions from @shpingalet007 in https://github.com/shpingalet007/pr-commands