Modernize build: update debian/control and debian/rules#3021
Merged
madeye merged 4 commits intoshadowsocks:masterfrom Feb 8, 2026
Merged
Modernize build: update debian/control and debian/rules#3021madeye merged 4 commits intoshadowsocks:masterfrom
madeye merged 4 commits intoshadowsocks:masterfrom
Conversation
Add obj-* in .gitignore
Replace libpcre3-dev with libpcre2-dev.
There was a problem hiding this comment.
Pull request overview
This PR modernizes Debian packaging/build-related files by updating regex library build dependencies, simplifying the debhelper configure step, and ignoring common CMake build artifact directories.
Changes:
- Update Debian Build-Depends from
libpcre3-devtolibpcre2-dev. - Simplify
debian/rulesby removing configure-style flags fromdh_auto_configure. - Add
obj-*to.gitignoreto ignore CMake build output directories.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
debian/rules |
Removes configure-style arguments from dh_auto_configure. |
debian/control |
Switches build dependency to libpcre2-dev. |
.gitignore |
Ignores obj-* build artifact directories. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| libmbedtls-dev, | ||
| libpcre3-dev, | ||
| libpcre2-dev, | ||
| libsodium-dev (>= 1.0.12), |
There was a problem hiding this comment.
If debian/rules is relying on CMake (as implied by removing configure-style flags), cmake needs to be listed in Build-Depends; otherwise builds in a clean Debian build environment will fail when dh_auto_configure invokes CMake.
Suggested change
| libsodium-dev (>= 1.0.12), | |
| libsodium-dev (>= 1.0.12), | |
| cmake, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
libpcre3-devwithlibpcre2-devin debian build-depends.Remove configure argument
--enable-sharedand--disable-ssp, cause cmake not use those arguments.Add
obj-*in .gitignore.