Skip to content

plot_common: use keyword "method" instead of "interpolation" #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sporksmith merged 1 commit into from
Jan 8, 2026
Merged

plot_common: use keyword "method" instead of "interpolation" #119

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions tornettools/plot_common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,13 +204,9 @@ def draw_cdf(axis, data, yscale=None, **kwargs):
d = [getfirstorself(item) for item in data]
y = __calc_cdf_bins(yscale, axis.gca().get_yaxis())

# the 'interpolation' parameter name is deprecated and replaced with
# 'method', but this change is recent so we'll stick with the deprecated
# name for now
# https://numpy.org/doc/stable/reference/generated/numpy.quantile.html
# the 'lower' is used to match the behaviour of 'draw_cdf_ci()' above
# https://github.com/shadow/tornettools/issues/76
x = quantile(d, y, interpolation='lower')
# the method 'lower' is used to match the behaviour of 'draw_cdf_ci()'
# above. See https://github.com/shadow/tornettools/issues/76
x = quantile(d, y, method='lower')

plot_line = axis.plot(x, y, **kwargs)
return plot_line[0]
Expand Down