Use a SwitchControllerRequest object instead of python argument mapping#97
Open
guihomework wants to merge 1 commit intoshadow-robot:melodic-develfrom
Open
Use a SwitchControllerRequest object instead of python argument mapping#97guihomework wants to merge 1 commit intoshadow-robot:melodic-develfrom
guihomework wants to merge 1 commit intoshadow-robot:melodic-develfrom
Conversation
… request, to be compatible with future API changes
ef80287 to
a1d36fb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Using a SwitchControllerRequest object instead of python argument mapping to a request object. This permits to be more "forward" compatible in case of future API changes that would break the current call if new parameters would be added (or changed place)
Types of changes
What types of changes does your code introduce?
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. This is a reminder of what we should look for before merging this code. I have: