Skip to content

Fix evaluation trigger and enhance benchmark metadata #450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
uygnef merged 3 commits into from
Jan 26, 2026
Merged

Fix evaluation trigger and enhance benchmark metadata #450

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
34c67a0
add offline eval args check and benchmark
uygnef Jan 23, 2026
4ca1f7c
clean up
uygnef Jan 23, 2026
f514521
clean up
uygnef Jan 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions benchmarks/bench_eagle3.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,9 @@ def main():
assert len(benchmark_list) != 0, "the number of benchmark list is 0"

base_url = f"http://localhost:{args.port}"

results = {}
results["model"] = server_args.speculative_draft_model_path

def run_benchmarks(batch_size: int, steps: int, topk: int, num_draft_tokens: int):
for benchmark_name, num_prompts, subset in benchmark_list:
Expand Down
18 changes: 15 additions & 3 deletions scripts/train_eagle3.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,6 +343,13 @@ def sanity_check(args: Namespace) -> None:
args.draft_accumulation_steps * args.sp_ulysses_size * args.sp_ring_size
)

if args.eval_data_path is not None and args.eval_hidden_states_path is not None:
raise ValueError(
"Cannot set both eval_data_path and eval_hidden_states_path. "
"For online mode, set only eval_data_path. "
"For offline mode, set only eval_hidden_states_path."
)


def build_draft_model(args: Namespace) -> Tuple[AutoDraftModelConfig, nn.Module]:
# Handle draft model config
Expand Down Expand Up @@ -906,9 +913,14 @@ def main():
# ================================================
# 7.2 Evaluation Step
# ================================================
if (
should_evaluate = (
args.eval_data_path is not None
and global_step % args.eval_interval == 0
or args.eval_hidden_states_path is not None
)
if (
should_evaluate
and global_step % (args.eval_interval * args.draft_accumulation_steps)
== 0
):
# Run evaluation
draft_model.eval()
Expand All @@ -935,7 +947,7 @@ def main():
args,
eval_acces,
eval_plosses,
global_step,
global_step // args.draft_accumulation_steps,
tracker,
mode="eval",
)
Expand Down