Skip to content

Conversation

@uygnef
Copy link
Collaborator

@uygnef uygnef commented Jan 22, 2026

Motivation

I identified an issue where input shifting is applied twice in the codebase:

preprocessing.py#L486

train_eagle3.py#L597

This double shifting results in the input_ids and target_ids being offset by 2 positions, causing a mismatch between embeddings and features. This leads to inconsistency between training and inference behavior.

Metric Before Changes After Changes Improvement
Output Throughput 100.57 117.16 +16.46%
Accept Length 1.66 1.93 +16.23%

Modifications

Related Issues

Accuracy Test

Benchmark & Profiling

Checklist

@gemini-code-assist
Copy link
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@jiapingW jiapingW self-requested a review January 22, 2026 08:30
@jiapingW jiapingW marked this pull request as ready for review January 22, 2026 08:30
@jiapingW jiapingW merged commit 30f474a into sgl-project:main Jan 22, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants