bug fix: duplicate padding for offline mode #448
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I identified an issue where input shifting is applied twice in the codebase:
preprocessing.py#L486
train_eagle3.py#L597
This double shifting results in the input_ids and target_ids being offset by 2 positions, causing a mismatch between embeddings and features. This leads to inconsistency between training and inference behavior.
Modifications
Related Issues
Accuracy Test
Benchmark & Profiling
Checklist