Skip to content

Flag TagHelper improvements #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
reijervano wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Flag TagHelper improvements #47

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4ef12ce
- Added id to checkbox
Jul 19, 2021
10b76d5
Added extra checks and made the ViewContext public
Jul 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 36 additions & 3 deletions Sakura.AspNetCore.Extensions/Sakura.AspNetCore.Mvc.TagHelpers/FlagsEnumInputTagHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
using System;
using JetBrains.Annotations;
using Microsoft.AspNetCore.Mvc.Rendering;
using Microsoft.AspNetCore.Mvc.TagHelpers;
using Microsoft.AspNetCore.Mvc.ViewFeatures;
using Microsoft.AspNetCore.Razor.TagHelpers;
Expand All @@ -26,9 +27,10 @@ public class FlagsEnumInputTagHelper : TagHelper
/// Creates a new <see cref="InputTagHelper" />.
/// </summary>
[UsedImplicitly(ImplicitUseKindFlags.InstantiatedNoFixedConstructorSignature)]
public FlagsEnumInputTagHelper(IHtmlGenerator htmlGenerator)
public FlagsEnumInputTagHelper(IHtmlGenerator htmlGenerator, IHtmlHelper htmlHelper)
{
HtmlGenerator = htmlGenerator;
HtmlHelper = htmlHelper;
}

/// <inheritdoc />
Expand All @@ -43,6 +45,18 @@ public FlagsEnumInputTagHelper(IHtmlGenerator htmlGenerator)
[PublicAPI]
protected IHtmlGenerator HtmlGenerator { get; }

/// <summary>
/// The <see cref="IHtmlHelper" /> Service object.
/// </summary>
[PublicAPI]
protected IHtmlHelper HtmlHelper { get; }

/// <summary>
/// The <see cref="ViewContext" /> Service object.
/// </summary>
[ViewContext]
public ViewContext ViewContext { get; set; }

/// <summary>
/// Get or set the model expression to retrieve the enum flag value from model.
/// </summary>
Expand Down Expand Up @@ -74,7 +88,6 @@ public override void Process(TagHelperContext context, TagHelperOutput output)
throw new InvalidOperationException(
$"The model expression type must be enum flag when {EnumFlagValueAttributeName} is specified");


// Get base type and remove nullable
var type = EnumFlagFor.ModelExplorer.ModelType;
type = Nullable.GetUnderlyingType(type) ?? type;
Expand All @@ -85,8 +98,28 @@ public override void Process(TagHelperContext context, TagHelperOutput output)
throw new InvalidOperationException(
$"The value of the {EnumFlagValueAttributeName} attribute is not a valid enum flag item.");

var name = "";
if (ViewContext != null)
{
((IViewContextAware)HtmlHelper).Contextualize(ViewContext);

// Now you can use the HtmlFieldPrefix if set
name = ViewContext.ViewData.TemplateInfo.HtmlFieldPrefix;
if (!string.IsNullOrEmpty(name))
{
name += ".";
}
}

name += EnumFlagFor.Name;

// Set id if possible
if (ViewContext != null)
{
output.Attributes.SetAttribute("id", HtmlHelper.GenerateIdFromName($"{name}.{enumName}"));
}
// Set name and value
output.Attributes.SetAttribute("name", EnumFlagFor.Name);
output.Attributes.SetAttribute("name", name);
output.Attributes.SetAttribute("value", enumName);

// Set checked attribute
Expand Down