fix: address linter findings and harden runtime correctness#88
Merged
Conversation
- processor: drop leaked cancel in WithContext (gosec G118); route
cancellation through stopCh/parentDone and close readers in Stop()
- executor: convert isStarted/isFinished to atomic.Bool; treat
exec.ErrWaitDelay and context.Canceled-with-ProcessState as non-failures
- executor: validate raw command path before filepath.Clean to catch
/../etc/passwd-style traversal that Clean silently normalizes away
- main: install signal handlers before exec.Start() to avoid orphaning
the child; bound shutdown with killTimeout; derive signal exit codes
from signalExitCodeBase+sig and surface non-exit errors as 1
- filter: pass lines with no detected level so plain output is no longer
silently dropped by include/exclude level rules
- formatter: getColorCode returns (string, error) and rejects unknown
color names; templateReferencesLine recognizes {{- .Line trim syntax
- config: skip filter validation when disabled; dedupe include/exclude
pattern checks via validateFilterPatterns
- tests: add goleak TestMain to every package; pin Go via
go-version-file in linter workflow; add go.uber.org/goleak v1.3.0
Closes #87
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cancellation through stopCh/parentDone and close readers in Stop()
exec.ErrWaitDelay and context.Canceled-with-ProcessState as non-failures
/../etc/passwd-style traversal that Clean silently normalizes away
the child; bound shutdown with killTimeout; derive signal exit codes
from signalExitCodeBase+sig and surface non-exit errors as 1
silently dropped by include/exclude level rules
color names; templateReferencesLine recognizes {{- .Line trim syntax
pattern checks via validateFilterPatterns
go-version-file in linter workflow; add go.uber.org/goleak v1.3.0
Closes #87