-
Notifications
You must be signed in to change notification settings - Fork 2
chore(deps): update dependency chai to v6 #175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
📦 Packages
|
1a97e15 to
7189e27
Compare
502efd8 to
0a87e64
Compare
0a87e64 to
9b1f321
Compare
9b1f321 to
e479ccd
Compare
92a3df3 to
2701a72
Compare
2701a72 to
b5eaf8c
Compare
b5eaf8c to
90f8a40
Compare
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
90f8a40 to
b19eaf0
Compare
| "devDependencies": { | ||
| "@iden3/js-merkletree": "1.5.1", | ||
| "chai": "5.3.3", | ||
| "chai": "6.2.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: The upgrade to Chai v6, an ESM-only library, is incompatible with the project's CommonJS test setup and will cause all tests to fail.
Severity: CRITICAL | Confidence: High
🔍 Detailed Analysis
The project is configured as a CommonJS module system, but the chai dependency is being upgraded to v6.2.2. This version of chai is ESM-only and does not support the CommonJS require() syntax used throughout the project's 36 test files. As a result, attempting to run the test suite will cause an ERR_REQUIRE_ESM error, leading to a complete failure of the test pipeline before any tests can be executed.
💡 Suggested Fix
Either revert the chai dependency to a v5.x version which supports CommonJS, or refactor the test suite to use ESM import syntax. The latter would also require adding "type": "module" to package.json or configuring the test runner for ES modules.
🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: zkp/js/package.json#L21
Potential issue: The project is configured as a CommonJS module system, but the `chai`
dependency is being upgraded to v6.2.2. This version of `chai` is ESM-only and does not
support the CommonJS `require()` syntax used throughout the project's 36 test files. As
a result, attempting to run the test suite will cause an `ERR_REQUIRE_ESM` error,
leading to a complete failure of the test pipeline before any tests can be executed.
Did we get this right? 👍 / 👎 to inform future reviews.
Reference ID: 7848328
This PR contains the following updates:
5.3.3->6.2.2Warning
Some dependencies could not be looked up. Check the Dependency Dashboard for more information.
Release Notes
chaijs/chai (chai)
v6.2.2Compare Source
What's Changed
New Contributors
Full Changelog: chaijs/chai@v6.2.1...v6.2.2
v6.2.1Compare Source
What's Changed
New Contributors
Full Changelog: chaijs/chai@v6.2.0...v6.2.1
v6.2.0Compare Source
What's Changed
Full Changelog: chaijs/chai@v6.1.0...v6.2.0
v6.1.0Compare Source
What's Changed
Adds an event emitter for hooking into method/property creation in #1693
Full Changelog: chaijs/chai@v6.0.2...v6.1.0
v6.0.1Compare Source
What's Changed
Full Changelog: chaijs/chai@v6.0.0...v6.0.1
v6.0.0Compare Source
BREAKING CHANGES
Chai is now bundled into a single file. The
lib/*.jsfiles are no longer present, and so any code that imports those files directly will need to change. The only file that can be imported now is./index.js.What's Changed
Full Changelog: chaijs/chai@v5.3.2...v6.0.0
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.