Skip to content

fix: return cancun #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
insider89 merged 1 commit into from
Dec 24, 2025
Merged

fix: return cancun #160

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/cli/commands/bootstrap/bootstrap.genesis-prompts.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ const createServiceStub = () => {
berlinBlock: 0,
londonBlock: 0,
shanghaiTime: 0,
cancunTime: 0,
zeroBaseFee: true,
},
nonce: "0x0",
Expand Down
1 change: 1 addition & 0 deletions src/cli/commands/bootstrap/bootstrap.selective-artifacts.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ const createSamplePayload = (filter: ArtifactFilter): OutputPayload => ({
berlinBlock: 0,
muirGlacierBlock: 0,
shanghaiTime: 0,
cancunTime: 0,
Comment on lines 49 to +52
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Dec 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better readability and to maintain consistency with the chronological order of Ethereum forks, it would be good to reorder these properties. The muirGlacierBlock fork occurred before the berlinBlock fork.

Suggested change
berlinBlock: 0,
muirGlacierBlock: 0,
shanghaiTime: 0,
cancunTime: 0,
muirGlacierBlock: 0,
berlinBlock: 0,
shanghaiTime: 0,
cancunTime: 0,

zeroBaseFee: false,
qbft: {
blockperiodseconds: 5,
Expand Down
2 changes: 2 additions & 0 deletions src/genesis/besu-genesis.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ type BesuGenesisConfig = {
readonly berlinBlock: number;
readonly londonBlock: number;
readonly shanghaiTime: number;
readonly cancunTime: number;
readonly zeroBaseFee: boolean;
readonly contractSizeLimit?: number;
readonly evmStackSize?: number;
Expand Down Expand Up @@ -117,6 +118,7 @@ export class BesuGenesisService {
berlinBlock: 0,
londonBlock: 0,
shanghaiTime: 0,
cancunTime: 0,
zeroBaseFee: (config.gasPrice ?? 0) === 0,
contractSizeLimit: config.contractSizeLimit,
evmStackSize: config.evmStackSize,
Expand Down
Loading