Use static errors for OIDC Token fetcher #64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethvargo
requested changes
Dec 10, 2025
Owner
sethvargo
left a comment
sethvargo
left a comment
There was a problem hiding this comment.
Hey hey - thanks for for the PR. I'm not sure this is the right approach (using wrapping). If this is desired, I think we want to create real concrete error types (with custom messages) instead.
Contributor
Author
|
My main use case is just that I want to tell the user in a more friendly way they need to enable permissions for idtoken if one of those env vars are missing. I think that would be easy to accomplish with my approach. But I can look into an updated proposal as well using concrete errors. |
Allows structured error handling in the consumer
marcusramberg
force-pushed
the
marcus/static_errors
branch
from
d0464ed to
8a56627
Compare
sethvargo
approved these changes
Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows structured error handling in the consumer