Skip to content

Handle empty project yml#10

Open
eschwartz wants to merge 4 commits into
sethfitz:masterfrom
aerisweather:handle-empty-project-yml
Open

Handle empty project yml#10
eschwartz wants to merge 4 commits into
sethfitz:masterfrom
aerisweather:handle-empty-project-yml

Conversation

@eschwartz
Copy link
Copy Markdown

This pull request includes:

  • Add integration tests using mocha.
    The integration tests run against a set of tmstyle/tmsource project file fixtures,
    and run all the way through the process of tile image generation.
    You can run the tests via npm test
    Motivation: I am interested in diving a little deeper into this project. However, there
    is enough functionality I don't understand, that it makes it a little scary to touch the code.
    Having some integration tests makes this less scary.
    Having more coverage would be great (I'm only testing a thin slice here).
  • Handle the error when an empty project.yml file is passed to tilelive-tmstyle.
    Previously, this resulted in an uncaught exception.
    Motivation: I'm using tilelive-tmstyle to power a tile server. We have been experiencing
    API timeouts on a regular basis, which have been really hard to track down.
    My suspicious is that uncaught exceptions within tiielive-tmstyle / tilelive-tmsource
    may be one of the causes of these timeouts.
    Better exception handling will allow me to log and track down the root cause of these errors.

Edan Schwartz added 4 commits September 7, 2016 12:09
previously this would cause an uncaughtException,
because the TypeError was not passed to the callback
@eschwartz eschwartz mentioned this pull request Sep 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant