Handle empty project yml#10
Open
eschwartz wants to merge 4 commits into
Open
Conversation
added 4 commits
September 7, 2016 12:09
previously this would cause an uncaughtException, because the TypeError was not passed to the callback
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes:
The integration tests run against a set of tmstyle/tmsource project file fixtures,
and run all the way through the process of tile image generation.
You can run the tests via
npm testMotivation: I am interested in diving a little deeper into this project. However, there
is enough functionality I don't understand, that it makes it a little scary to touch the code.
Having some integration tests makes this less scary.
Having more coverage would be great (I'm only testing a thin slice here).
project.ymlfile is passed to tilelive-tmstyle.Previously, this resulted in an uncaught exception.
Motivation: I'm using
tilelive-tmstyleto power a tile server. We have been experiencingAPI timeouts on a regular basis, which have been really hard to track down.
My suspicious is that uncaught exceptions within
tiielive-tmstyle/tilelive-tmsourcemay be one of the causes of these timeouts.
Better exception handling will allow me to log and track down the root cause of these errors.