Skip to content

OHOS: Include script to create sign.sh from build-profile.json#111

Merged
jschwe merged 4 commits intoservo:mainfrom
Narfinger:signing-py
Mar 3, 2026
Merged

OHOS: Include script to create sign.sh from build-profile.json#111
jschwe merged 4 commits intoservo:mainfrom
Narfinger:signing-py

Conversation

@Narfinger
Copy link
Contributor

Currently we need a sign.sh script which can be quite difficult to create. Thankfully https://github.com/TermonyHQ/Termony/blob/master/sign.js exists which we can use.
Sadly, a straightforward reimplementation into python didn't provide the correct results because the AESGCM seems to be different between node and python.
At the time of writing this code is under MIT license.

This PR just adds a small python script that downloads the js file and creates the sign.sh with the correct args.

Signed-off-by: Narfinger Narfinger@users.noreply.github.com

@Narfinger Narfinger marked this pull request as ready for review February 9, 2026 15:31
@Narfinger Narfinger requested a review from jschwe as a code owner February 9, 2026 15:31
Signed-off-by: Narfinger <Narfinger@users.noreply.github.com>
Signed-off-by: Narfinger <Narfinger@users.noreply.github.com>
Narfinger and others added 2 commits March 3, 2026 13:46
Co-authored-by: Jonathan Schwender <55576758+jschwe@users.noreply.github.com>
Signed-off-by: Narfinger <Narfinger@users.noreply.github.com>
Signed-off-by: Narfinger <Narfinger@users.noreply.github.com>
@jschwe jschwe merged commit 41d0074 into servo:main Mar 3, 2026
1 check passed
@Narfinger Narfinger deleted the signing-py branch March 3, 2026 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants