Reduce verbosity of use.authentications(...) DSL for OAuth2/OIDC#1513
Merged
Conversation
Signed-off-by: Matheus Cruz <matheuscruz.dev@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds convenience methods to the fluent use.authentications(...) builder to reduce nesting when defining named authentication policies, primarily for OAuth2/OIDC scenarios, and introduces unit tests to validate the new shorthands.
Changes:
- Introduces shorthand methods on
UseAuthenticationsBuilderforbasic,bearer,digest,oidc, andoauth2named authentications (including an overload supporting custom OAuth2 endpoints). - Adds comprehensive unit tests covering the new shorthand methods and fluent chaining of multiple named authentications.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| fluent/spec/src/main/java/io/serverlessworkflow/fluent/spec/UseAuthenticationsBuilder.java | Adds named-authentication shorthand methods to reduce DSL nesting and support OAuth2/OIDC configuration. |
| fluent/spec/src/test/java/io/serverlessworkflow/fluent/spec/UseAuthenticationsBuilderTest.java | Adds unit tests validating the new shorthand builders and chaining behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Matheus Cruz <matheuscruz.dev@gmail.com>
fjtirado
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many thanks for submitting your Pull Request ❤️!
What this PR does / why we need it:
Special notes for reviewers:
Additional information (if needed):
CLoses #1509