Add gRPC support to the fluent SDK with new DSL#1488
Open
matheusandre1 wants to merge 1 commit into
Open
Conversation
matheusandre1
force-pushed
the
issue1484
branch
3 times, most recently
from
d8aad6f to
9c75deb
Compare
Collaborator
|
@matheusandre1 Is this ready for review? |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds fluent-DSL support for defining gRPC call tasks (including a new step-based API in the experimental FuncDSL) and expands the gRPC integration tests to validate both YAML and fluent-built workflows.
Changes:
- Introduces experimental
FuncDSLgRPC call entrypoints (call(...)overloads +grpc()step) and supporting builders/SPIs/configurers. - Extends fluent spec task building with an additional
grpcoverload acceptingCallGrpcConfigurer. - Updates gRPC impl tests to run both YAML- and fluent-built workflows via parameterized tests.
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 12 comments.
Show a summary per file
| File | Description |
|---|---|
| impl/test/src/test/java/io/serverlessworkflow/impl/test/grpc/GrpcUnaryTest.java | Converts setup/teardown to per-test lifecycle and adds parameterized coverage for YAML vs fluent-built unary gRPC workflow. |
| impl/test/src/test/java/io/serverlessworkflow/impl/test/grpc/GrpcUnaryArgsExprTest.java | Adds parameterized coverage for unary gRPC workflow with argument expressions. |
| impl/test/src/test/java/io/serverlessworkflow/impl/test/grpc/GrpcServerStreamingTest.java | Adds parameterized coverage for server-streaming gRPC workflow (YAML vs fluent). |
| impl/test/src/test/java/io/serverlessworkflow/impl/test/grpc/GrpcClientStreamingTest.java | Adds parameterized coverage for client-streaming gRPC workflow (YAML vs fluent). |
| impl/test/src/test/java/io/serverlessworkflow/impl/test/grpc/GrpcBiDirectionalStreamingTest.java | Adds parameterized coverage for bidi-streaming gRPC workflow (YAML vs fluent). |
| impl/test/pom.xml | Adds test-scoped dependency on the experimental fluent func artifact. |
| fluent/spec/src/main/java/io/serverlessworkflow/fluent/spec/TaskItemListBuilder.java | Adds grpc(String, CallGrpcConfigurer) overload in the fluent spec task list builder. |
| experimental/fluent/func/src/main/java/io/serverlessworkflow/fluent/func/spi/FuncDoFluent.java | Wires gRPC fluent support into the experimental “do” fluent interface. |
| experimental/fluent/func/src/main/java/io/serverlessworkflow/fluent/func/spi/CallGrpcFluent.java | New SPI interface enabling grpc(...) in experimental func fluent tasks. |
| experimental/fluent/func/src/main/java/io/serverlessworkflow/fluent/func/FuncTaskItemListBuilder.java | Implements grpc(...) task creation for experimental func task lists. |
| experimental/fluent/func/src/main/java/io/serverlessworkflow/fluent/func/FuncDoTaskBuilder.java | Adds grpc(...) to the experimental “do” task builder. |
| experimental/fluent/func/src/main/java/io/serverlessworkflow/fluent/func/FuncCallGrpcTaskBuilder.java | New builder that constructs CallGRPC tasks with default GRPCArguments. |
| experimental/fluent/func/src/main/java/io/serverlessworkflow/fluent/func/dsl/FuncDSL.java | Adds gRPC call entrypoints and gRPC step factory methods to experimental FuncDSL. |
| experimental/fluent/func/src/main/java/io/serverlessworkflow/fluent/func/dsl/FuncCallGrpcStep.java | New step-based fluent builder for configuring gRPC call tasks in experimental DSL. |
| experimental/fluent/func/src/main/java/io/serverlessworkflow/fluent/func/configurers/FuncCallGrpcConfigurer.java | New functional configurer type for low-level gRPC call configuration in experimental DSL. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Matheus André <matheusandr2@gmail.com>
Comment on lines
+172
to
+175
| public TaskItemListBuilder grpc(String name, CallGrpcConfigurer configurer) { | ||
| Consumer<CallGrpcTaskBuilder> consumer = configurer; | ||
| return grpc(name, consumer); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
no, maintaining this overload is necessary to ensure consistency with other grpc methods.
Comment on lines
+21
to
+27
| public interface CallGrpcFluent<SELF extends TaskBaseBuilder<SELF>, LIST> { | ||
|
|
||
| LIST grpc(String name, Consumer<SELF> itemsConfigurer); | ||
|
|
||
| default LIST grpc(Consumer<SELF> itemsConfigurer) { | ||
| return this.grpc(null, itemsConfigurer); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Removing this would require changing the hierarchy of the FuncDoFluent types and would break the structure of the other module.
fjtirado
approved these changes
Jul 2, 2026
Collaborator
|
@ricardozanini Can you review? |
ricardozanini
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many thanks for submitting your Pull Request ❤️!
What this PR does / why we need it:
This is Pull Request covers
FuncDSL.grpcgaps and I created layers tests hereAdditional information (if needed):
Closes: #1484