Style start/end node components #202
Conversation
Signed-off-by: kumaradityaraj <sedulous.0007@gmail.com>
✅ Deploy Preview for swf-editor ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
This PR replaces the placeholder Start/End React Flow nodes with a dedicated StartEndNode component and introduces corresponding CSS to render Mermaid-style start (single circle) and end (double circle) markers in the workflow diagram editor.
Changes:
- Added a shared
StartEndNoderenderer and wired it intoStartNode/EndNode. - Added new CSS classes for start/end node shapes, plus selected/hover styling.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| packages/serverless-workflow-diagram-editor/src/react-flow/nodes/Nodes.tsx | Adds StartEndNode and updates Start/End node components to render it. |
| packages/serverless-workflow-diagram-editor/src/react-flow/diagram/Diagram.css | Adds styling for the new start/end node shapes and their interaction states. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@kumaradityaraj I know not ready for review but I know I mentioned the grey like the edge but looks a bit off next to diagram, can you try the same colours as what we style the entry/exit nodes for light and dark themes please |
Signed-off-by: kumaradityaraj <sedulous.0007@gmail.com>
Signed-off-by: kumaradityaraj <sedulous.0007@gmail.com>
Signed-off-by: kumaradityaraj <sedulous.0007@gmail.com>
Signed-off-by: kumaradityaraj <sedulous.0007@gmail.com>
|
@lornakelly @fantonangeli @handreyrc Please review this PR. Special attention to colour of the node must be verified as mentioned by Lorna in the above comment. |
|
@kumaradityaraj It doesnt look like the colours are updated to match entry/exit nodes? Once that is done I will review rest of PR, thanks |
Signed-off-by: kumaradityaraj <sedulous.0007@gmail.com>
Signed-off-by: kumaradityaraj <sedulous.0007@gmail.com>
Signed-off-by: kumaradityaraj <sedulous.0007@gmail.com>
Signed-off-by: kumaradityaraj <sedulous.0007@gmail.com>
Signed-off-by: kumaradityaraj <sedulous.0007@gmail.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
Comments suppressed due to low confidence (2)
packages/serverless-workflow-diagram-editor/src/react-flow/diagram/Diagram.css:410
- In this stylesheet’s
@layer custom-nodes, selectors are consistently scoped under.dec-root(e.g..dec-root .custom-node-container). These new Start/End node styles are unscoped, which can leak styling outside the editor root and behave inconsistently with the rest of the file.
box-shadow:
0 0 0 2px var(--dec-error-accent),
0 0 0 4px rgb(59 130 246),
0 0 12px 4px rgba(59, 130, 246, 0.45);
}
packages/serverless-workflow-diagram-editor/src/react-flow/diagram/Diagram.css:417
- These selectors should also be scoped under
.dec-rootfor consistency and to avoid leaking global styles.
.dec-root.dark .dec-container-node.has-error.selected {
box-shadow:
0 0 0 2px var(--dec-error-accent),
0 0 0 4px rgb(96 165 250),
0 0 16px 4px rgba(96, 165, 250, 0.5);
Signed-off-by: kumaradityaraj <sedulous.0007@gmail.com>
Signed-off-by: kumaradityaraj <sedulous.0007@gmail.com>
Signed-off-by: kumaradityaraj <sedulous.0007@gmail.com>
Signed-off-by: kumaradityaraj <sedulous.0007@gmail.com>
|
@handreyrc @fantonangeli @cheryl7114 please review this. |
fantonangeli
left a comment
There was a problem hiding this comment.
LGTM, 1 small comment only
Signed-off-by: kumaradityaraj <sedulous.0007@gmail.com>
|
@ricardozanini please review and merge this pr. |



Closes
Style Start and End Nodes and Verify Edge Connectivity
Summary
This PR applies the finalized styling for the custom Start and End workflow nodes and validates their connectivity within the editor. The implementation aligns with the agreed design, providing clear visual indicators for workflow entry and exit points.
Changes
Screenshots