Implement navigation progress indicator and account invitation feature#8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several enhancements and refactors to the admin application, focusing on improved navigation handling, user experience, and account management features. The most notable changes are the migration to a custom navigation hook for routing, the addition of an account invitation email feature, and documentation updates for clearer setup and structure. Below are the top changes grouped by theme:
Navigation and Routing Improvements:
useRouterwith a customuseNavigationRouterhook across multiple components (edit-account.tsx,account-list.tsx,account-search.tsx,create-account.tsx), standardizing navigation logic and simplifying code. (apps/admin/src/app/(app)/system/accounts/[id]/edit/_parts/edit-account.tsxL4, apps/admin/src/app/(app)/system/accounts/[id]/edit/_parts/edit-account.tsxR23, apps/admin/src/app/(app)/system/accounts/[id]/edit/_parts/edit-account.tsxL33-R33, apps/admin/src/app/(app)/system/accounts/[id]/edit/_parts/edit-account.tsxL57-R57, apps/admin/src/app/(app)/system/accounts/[id]/edit/_parts/edit-account.tsxL78-R78, apps/admin/src/app/(app)/system/accounts/[id]/edit/_parts/edit-account.tsxL202-R202, [1] [2] [3] [4] [5] [6] [7] [8]NavigationProgressProviderinapp-layout.tsxto enable navigation progress tracking, and added a visual indicator component (link-indicator.tsx) for page transitions. [1] [2] [3] [4] [5]Account Creation and Invitation Email Feature:
sendInviteboolean field to account creation forms and schema, allowing admins to optionally send an invitation email to new accounts. [1] [2] [3] [4]InviteEmail) and mail utility whensendInviteis enabled. Errors in sending mail no longer block account creation. [1] [2] [3]UI Consistency and Refactoring:
Linkcomponent with a customLinkcomponent throughout navigation and sidebar files for consistent styling and behavior. [1] [2]Documentation and Environment Updates:
README.mdandapps/admin/README.mdto clarify project structure, setup steps, and local development tips, including infrastructure details and mail confirmation instructions. [1] [2].env.templateto include SES endpoint and mail sender settings for local development.