Skip to content

Filenames that begin and end with spaces are valid in *nix. #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mike-odom wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Filenames that begin and end with spaces are valid in *nix. #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/parser.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ var RE_UnixEntry = new RegExp(

// year (for non-recent standard format)
// or time (for numeric or recent standard format)
+ "(\\d+(?::\\d+)?)\\s*"
+ "(\\d+(?::\\d+)?)\\s"

//+ "(\\S*)(\\s*.*)"
+ "(.*)"
Expand Down
25 changes: 24 additions & 1 deletion test/parser.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -497,7 +497,8 @@ drwx------ 2 1001 1001 4096 Oct 19 16:17 project2\r\n";
-drwxr-x--- 2 userName alternc 4096 Aug 22 03:45 .\r\n\
-drwxr-x--- 5 userName alternc 4096 Aug 22 03:45 ..\r\n\
--rw-r----- 1 userName alternc 460 Aug 22 03:45 test1\r\n\
--rw-r----- 1 userName alternc 560 Aug 22 03:47 test2\r\n";
--rw-r----- 1 userName alternc 560 Aug 22 03:47 test2\r\n\
--rw-r----- 1 userName alternc 560 Aug 22 03:49 spaceTest \n";

var unixEntries2 = [
{
Expand Down Expand Up @@ -538,6 +539,28 @@ drwx------ 2 1001 1001 4096 Oct 19 16:17 project2\r\n";
groupWritePerm: false,
groupExecPerm: false,

otherReadPerm: false,
otherWritePerm: false,
otherExecPerm: false
},
{
//Testing for whitespace at start and end of line, valid in unix
//line: --rw-r----- 1 userName alternc 560 Aug 22 03:49 spaceTest "
type: 0,
size: 560,
name: " spaceTest ",
time: +new Date("Aug 22 03:49 " + new Date().getFullYear()),
owner: "userName",
group: "alternc",

userReadPerm: true,
userWritePerm: true,
userExecPerm: false,

groupReadPerm: true,
groupWritePerm: false,
groupExecPerm: false,

otherReadPerm: false,
otherWritePerm: false,
otherExecPerm: false
Expand Down