Add banner upload functionality to the shop home screen#59
Open
AleksandarBoljanovic wants to merge 19 commits into
Open
Add banner upload functionality to the shop home screen#59AleksandarBoljanovic wants to merge 19 commits into
AleksandarBoljanovic wants to merge 19 commits into
Conversation
LIS-111
LIS-111
LIS-111
LIS-111
LIS-111
LIS-111
LIS-111
ISSUE: LIS-111
ISSUE: LIS-111
ISSUE: LIS-111
# Conflicts: # tests/BusinessLogic/Domain/Disconnect/Services/DisconnectServiceTest.php
ISSUE: LIS-111
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the goal?
References
How is it being implemented?
BannerCheckoutController) withgetBannerForLocationendpoint, request and response - used by the storefront to fetch the banner to render for a given country/display locationget-banner-settings,save-banner-settings)BannerSettingsdomain context:BannerandBannerSettingsmodels,BannerSettingsentity withEntityConfiguration,BannerSettingsRepositoryInterface+ repository, andBannerSettingsServiceorchestrating fetch/save/delete and display-location-aware image updatesBannerServiceInterface) as the platform extension point - exposes display locations, image upload/delete, and country lookup so each e-commerce platform supplies its own implementationBANNERcapability toCapabilityand surfaced it viaStoreIntegrationServiceso platforms can advertise banner supportConnectionServicetriggers banner-settings provisioning on connect,DisconnectServicecleans up persisted settings and uploaded images on disconnect (with an error log if image deletion on the integration side fails)BootstrapComponent(repository, service, controllers, webhook handlers)How is it tested?