๐ (study) 8์ฃผ์ฐจ API ๋๋ฉด ์๋ฃ ๋ณด๊ฐ#22
Conversation
|
Caution Review failedThe pull request is closed. โน๏ธ Recent review infoโ๏ธ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ๐ Files selected for processing (1)
๐ WalkthroughWalkthroughWeek 8 in-person lecture extensively rewritten to position API interactions as frontend-backend contracts, expanded with CORS curriculum and modern API integration patterns. Week 6, 9, and 11 course overviews synchronized to reflect curriculum shift from web security topics to Next.js rendering and performance in week 9. ChangesAPI Contract-Driven API Learning & Curriculum Alignment
Estimated code review effort๐ฏ 2 (Simple) | โฑ๏ธ ~12 minutes Possibly related PRs
Poem
๐ฅ Pre-merge checks | โ 4 | โ 1โ Failed checks (1 inconclusive)
โ Passed checks (4 passed)
โ๏ธ Tip: You can configure your own custom pre-merge checks in the settings. โจ Finishing Touches๐งช Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. ๐ง ESLint
apps/web/content/study/clab-26-1/in-person/week8.mdxOops! Something went wrong! :( ESLint: 9.39.4 Error [ERR_MODULE_NOT_FOUND]: Cannot find package '@eslint/js' imported from /packages/config/eslint/base.js Tip ๐ฌ Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. ๐ Get started Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying with ย
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| โ
Deployment successful! View logs |
seojing | 35dc158 | Commit Preview URL Branch Preview URL |
May 14 2026, 01:35 PM |
There was a problem hiding this comment.
Actionable comments posted: 1
๐ค Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@apps/web/content/study/clab-26-1/in-person/week8.mdx`:
- Around line 463-468: The example uses localStorage.getItem("accessToken")
inside apiClient.interceptors.request.use which can be misread as a recommended
production pattern; update the MDX around this snippet to add a clear security
note stating this is a simple learning example, warn about XSS risks of storing
tokens in localStorage, and recommend using HttpOnly + Secure cookies
(server-set session/refresh cookies) or other secure storage flows as the
preferred production approach; mention briefly that with cookies the server
handles token storage and CSRF/SameSite considerations and link or point readers
to implement refresh-token flows instead of client-side localStorage.
๐ช Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
โน๏ธ Review info
โ๏ธ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: dd4d7e34-38a2-4c18-a0c0-aaf6acc5a04b
๐ Files selected for processing (5)
apps/web/content/study/clab-26-1/in-person/week11.mdxapps/web/content/study/clab-26-1/in-person/week6-1.mdxapps/web/content/study/clab-26-1/in-person/week8.mdxapps/web/content/study/clab-26-1/in-person/week9.mdxapps/web/content/study/clab-26-1/week9.mdx
|
CodeRabbit์ localStorage ํ ํฐ ์ ์ฅ ๋ณด์ ์ง์ ๋ฐ์ํ์ต๋๋ค. ํ์ต์ฉ ๋จ์ ์์์์ ๋ช ์ํ๊ณ , XSS ์ํ ๋ฐ HttpOnly + Secure + SameSite ์ฟ ํค ๊ธฐ๋ฐ ์ธ์ฆ์ ์ค๋ฌด ๋์์ผ๋ก ์ถ๊ฐํ์ต๋๋ค. Refresh Token ์น์ ์๋ ์ฟ ํค ๊ธฐ๋ฐ ์ธ์ฆ ์ CSRF/SameSite/CORS credentials๋ฅผ ๋ฐฑ์๋์ ๋ง์ถฐ์ผ ํ๋ค๋ ์ค๋ช ์ ๋ณด๊ฐํ์ต๋๋ค. |
|
Codecov Reportโ All modified and coverable lines are covered by tests. ๐ข Thoughts on this report? Let us know! |
์์
๊ฒ์ฆ
pnpm build์ฑ๊ณต๋ฉ๋ชจ
main๊ธฐ์ค์ผ๋ก ๋ถ๋ฆฌํ์ต๋๋ค.Summary by CodeRabbit