🤖 Refactor processDeliveryItem to handle checkout success/failure#160
Draft
seer-by-sentry[bot] wants to merge 1 commit intomainfrom
Draft
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #160 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 15 15
Lines 780 783 +3
Branches 43 43
=====================================
- Misses 780 783 +3 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👋 Hi there! This PR was automatically generated by Autofix 🤖
This fix was triggered by simon.zhong@sentry.io
Fixes ANDROID-12D
processDeliveryItemto accept a booleancheckoutSuccessparameter.checkoutSuccessis false, logs an error and sets the span status to INVALID_ARGUMENT without throwing an exception.checkoutSuccessis true, proceeds with delivery processing logic.processDeliveryItemwhen checkout fails.processDeliveryItemwhen checkout succeeds.If you have any questions or feedback for the Sentry team about this fix, please email autofix@sentry.io with the Run ID: 6076.