Fix crash if itunes extensions are missing#668
Merged
sentriz merged 1 commit intosentriz:masterfrom Mar 10, 2026
Merged
Conversation
Contributor
Author
|
Here is where the generator uses the rss crate. rss::ChannelBuilder would need a itunesExtension parameter to output these. As it seems to be an extension I'd consider expecting it to be there a bug. |
sentriz
reviewed
Mar 9, 2026
I came across this issue when I started to use a custom RSS generator that works fine for e.g. the Apple Podcasts app but results in a crash in gonic. I found these nil pointer dereferences by looking at the stacktraces only. No time was spent looking for additional locations were this might need to be fixed. The custom generator if that helps https://gist.github.com/diepfote/59aaf5eb8ea3e2d7bcdd97b8efd2a472
diepfote
force-pushed
the
fix-crash-itunes-ext
branch
from
b80bd23 to
297c918
Compare
Owner
|
thanks! |
lurenyang418
pushed a commit
to lurenyang418/gonic
that referenced
this pull request
Mar 23, 2026
…entriz#668) | Before | After | | - | - | | <img width="341" alt="image" src="https://github.com/user-attachments/assets/452d57b1-5ec6-4ad3-bc30-ed8a966d12e5" /> | <img width="350" alt="image" src="https://github.com/user-attachments/assets/9f664cea-aa55-479a-8d5b-61570101a66f" /> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I came across this issue when I started to use a custom RSS generator that works fine for e.g. the Apple Podcasts app but results in a crash in gonic.
I found these nil pointer dereferences by looking at the stacktraces only.
No time was spent looking for additional locations were this might need to be fixed.
The custom generator if that helps
https://gist.github.com/diepfote/59aaf5eb8ea3e2d7bcdd97b8efd2a472