Closed
Conversation
Owner
|
hm I wonder do we need the config option at all? can we just allow relative paths? joining on the basedir if the playlist line doesn't look absolute with no leading slash |
Author
|
the option mostly determines if the playlist is written with absolute or relative paths, I modified the reader so it does exactly what you described regardless of config option |
Author
|
If you'd like I can remove the config check during writes from the PR, but I think there's a lot of situations where absolute paths would still make sense (ie having playlists and music on separate volumes) |
Author
|
heya, just checking in. Let me know if you'd like this merged in! |
sentriz
force-pushed
the
master
branch
5 times, most recently
from
7decea6 to
971d22d
Compare
lurenyang418
pushed a commit
to lurenyang418/gonic
that referenced
this pull request
Mar 23, 2026
<img width="387" alt="image" src="https://github.com/user-attachments/assets/b3d3f2a8-dc4e-49e6-8e82-e7f551d70bc7" />
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #529
Improves portability between machines by optionally making file paths relative to the playlist
feedback welcome! it's my first time writing go