Closed
Conversation
added 18 commits
August 5, 2023 15:19
TODO: Make the styles match the rest of the page and move them out of inline.
ghost
Owner
|
thanks for the effort here 👍 it also may take some time for me to review since i don't know anything about LDAP. and i don't think i should blindy accept something i don't know about (no offense 😁) i will do some reading or get a second pair of eyeballs on it there seems to be some lint errors btw |
Author
@nitnelave, this has been done in fccf016. |
sentriz
reviewed
May 4, 2024
Owner
sentriz
left a comment
sentriz
left a comment
There was a problem hiding this comment.
hi there seems like there some lint errors
sentriz
force-pushed
the
master
branch
3 times, most recently
from
c5b3a1c to
86fd590
Compare
Open
sentriz
force-pushed
the
master
branch
5 times, most recently
from
7decea6 to
971d22d
Compare
ghost
closed this by deleting the head repository
lurenyang418
pushed a commit
to lurenyang418/gonic
that referenced
this pull request
Mar 23, 2026
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Limitations
Fixes: #44.