Skip to content

chore(ci): report-only coverage job for sentrix-core (non-blocking)#778

Merged
github-actions[bot] merged 1 commit into
mainfrom
chore/sentrix-core-coverage
Jun 3, 2026
Merged

chore(ci): report-only coverage job for sentrix-core (non-blocking)#778
github-actions[bot] merged 1 commit into
mainfrom
chore/sentrix-core-coverage

Conversation

@satyakwok
Copy link
Copy Markdown
Collaborator

Follow-up to #777. Adds a sentrix-core coverage number without any risk to the required gate or to Codecov.

Why

sentrix-core is excluded from the required cargo-llvm-cov job (coverage.yml) because llvm-cov instrumentation of the revm dep tree is brittle on CI runners. So the new apply-path / fingerprint / native-module logic from #775/#776 has no coverage number in CI.

What

A standalone coverage-sentrix-core.yml:

  • Not required — its job name isn't in the branch ruleset's required checks (Test, cargo audit, gitleaks, cargo-llvm-cov, Dependency review, commitlint), so it can never block a merge.
  • continue-on-error: true — if revm instrumentation flakes on the runner, it's a soft failure, not a red gate.
  • No Codecov upload — no codecov/codecov-action step, so it cannot move project/patch coverage.
  • Artifact only — publishes sentrix-core-lcov.info + a text summary as a downloadable CI artifact.
  • Triggers only on PRs touching crates/sentrix-core/** + workflow_dispatch.

Does not modify coverage.yml or codecov.yml.

Local verification

  • cargo test -p sentrix-core ✅ (clean, ~37s, no flakiness)
  • cargo llvm-cov -p sentrix-core --summary-only ✅ ~49s warm → 82.5% regions / 77.9% lines (incl. the new vm.rs 86.7%, nft.rs apply path)

Risk

Low. Worst case = the report-only job is slow or flakes on CI; because it's non-required + continue-on-error + artifact-only, that has zero impact on merges or the codecov number. Promoting sentrix-core into the required coverage upload stays deferred until revm instrumentation is proven reliable on CI.

No protocol logic, RPC, explorer, wallet, marketplace, or bridge changes. No deploy.

sentrix-core is excluded from the required `cargo-llvm-cov` job because
llvm-cov instrumentation of the revm dep tree is brittle on CI runners.
Add a standalone, non-blocking job so we still get a sentrix-core coverage
number without any risk to the required gate or to Codecov.

- separate workflow; job name is NOT in the branch ruleset's required
  status checks, so it can never block a merge
- continue-on-error: true → flaky/failed instrumentation is a soft failure
- no codecov/codecov-action step → cannot change Codecov project/patch
- publishes lcov + text summary as a downloadable CI artifact only
- triggers only on PRs touching crates/sentrix-core/** + manual dispatch

Does not modify coverage.yml or codecov.yml. Promote sentrix-core into the
main coverage upload only once revm instrumentation is reliable on CI.
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 3, 2026

Warning

Review limit reached

@satyakwok, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 19 minutes and 33 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 33d17251-7a00-47ab-af0a-7eb96f003835

📥 Commits

Reviewing files that changed from the base of the PR and between a20e844 and 6461942.

📒 Files selected for processing (1)
  • .github/workflows/coverage-sentrix-core.yml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/sentrix-core-coverage

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot enabled auto-merge (squash) June 3, 2026 18:09
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@satyakwok satyakwok self-assigned this Jun 3, 2026
@github-actions github-actions Bot merged commit b8346f6 into main Jun 3, 2026
18 checks passed
@satyakwok satyakwok deleted the chore/sentrix-core-coverage branch June 3, 2026 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant