Skip to content

Commit b4ff13e

Browse files
author
SendGrid's DX Team
authored
Merge branch 'master' into contenttype
2 parents aee9956 + 79bb80e commit b4ff13e

File tree

5 files changed

+15
-9
lines changed

5 files changed

+15
-9
lines changed

CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,12 @@ All notable changes to this project will be documented in this file.
33

44
This project adheres to [Semantic Versioning](http://semver.org/).
55

6+
## [3.0.1] - 2016-01-25
7+
### Fix
8+
- [Pull Request #7](https://github.com/sendgrid/ruby-http-client/pull/7)
9+
- Fixes [issue #6](https://github.com/sendgrid/ruby-http-client/issues/6): TLS certificates not verified
10+
- Thanks to [Koen Rouwhorst](https://github.com/koenrh) for the pull request!
11+
612
## [3.0.0] - 2016-07-23
713
### BREAKING CHANGE
814
- Implements [issue #3](https://github.com/sendgrid/ruby-http-client/issues/3): Headers on Response

CONTRIBUTING.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,13 +16,13 @@ We use [Milestones](https://github.com/sendgrid/ruby-http-client/milestones) to
1616
<a name="cla"></a>
1717
## CLAs and CCLAs
1818

19-
Before you get started, SendGrid requires that a SendGrid Contributor License Agreement (CLA) or a SendGrid Company Contributor Licensing Agreement (CCLA) be filled out by every contributor to a SendGrid open source project.
19+
Before you get started, SendGrid requires that a SendGrid Contributor License Agreement (CLA) be filled out by every contributor to a SendGrid open source project.
2020

21-
Our goal with the CLA and CCLA is to clarify the rights of our contributors and reduce other risks arising from inappropriate contributions. The CLA also clarifies the rights SendGrid holds in each contribution and helps to avoid misunderstandings over what rights each contributor is required to grant to SendGrid when making a contribution. In this way the CLA and CCLA encourage broad participation by our open source community and help us build strong open source projects, free from any individual contributor withholding or revoking rights to any contribution.
21+
Our goal with the CLA is to clarify the rights of our contributors and reduce other risks arising from inappropriate contributions. The CLA also clarifies the rights SendGrid holds in each contribution and helps to avoid misunderstandings over what rights each contributor is required to grant to SendGrid when making a contribution. In this way the CLA encourages broad participation by our open source community and helps us build strong open source projects, free from any individual contributor withholding or revoking rights to any contribution.
2222

23-
SendGrid does not merge a pull request made against a SendGrid open source project until that pull request is associated with a signed CLA (or CCLA). Copies of the CLA and CCLA are available [here](https://drive.google.com/a/sendgrid.com/file/d/0B0PlcM9qA91LN2VEUTJWU2RIVXc/view).
23+
SendGrid does not merge a pull request made against a SendGrid open source project until that pull request is associated with a signed CLA. Copies of the CLA are available [here](https://gist.github.com/SendGridDX/98b42c0a5d500058357b80278fde3be8#file-sendgrid_cla).
2424

25-
You may submit your completed [CLA or CCLA](https://drive.google.com/a/sendgrid.com/file/d/0B0PlcM9qA91LN2VEUTJWU2RIVXc/view) to SendGrid at [dx@sendgrid.com](mailto:dx@sendgrid.com). SendGrid will then confirm you are ready to begin making contributions.
25+
When you create a Pull Request, after a few seconds, a comment will appear with a link to the CLA. Click the link and fill out the brief form and then click the "I agree" button and you are all set. You will not be asked to re-sign the CLA unless we make a change.
2626

2727
There are a few ways to contribute, which we'll enumerate below:
2828

@@ -191,4 +191,4 @@ Please run your code through:
191191
7. [Open a Pull Request](https://help.github.com/articles/using-pull-requests/)
192192
with a clear title and description against the `master` branch. All tests must be passing before we will review the PR.
193193

194-
If you have any additional questions, please feel free to [email](mailto:dx@sendgrid.com) us or create an issue in this repo.
194+
If you have any additional questions, please feel free to [email](mailto:dx@sendgrid.com) us or create an issue in this repo.

lib/ruby_http_client.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -184,7 +184,7 @@ def add_ssl(http)
184184
protocol = host.split(':')[0]
185185
if protocol == 'https'
186186
http.use_ssl = true
187-
http.verify_mode = OpenSSL::SSL::VERIFY_NONE
187+
http.verify_mode = OpenSSL::SSL::VERIFY_PEER
188188
end
189189
http
190190
end

ruby_http_client.gemspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
44

55
Gem::Specification.new do |spec|
66
spec.name = 'ruby_http_client'
7-
spec.version = '3.0.0'
7+
spec.version = '3.0.1'
88
spec.authors = ['Elmer Thomas']
99
spec.email = 'dx@sendgrid.com'
1010
spec.summary = 'A simple REST client'

test/test_ruby_http_client.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -156,8 +156,8 @@ def add_ssl
156156
uri = URI.parse('https://localhost:4010')
157157
http = Net::HTTP.new(uri.host, uri.port)
158158
http = @client.add_ssl(http)
159-
assert_equal(true, http.use_ssl)
160-
assert_equal(OpenSSL::SSL::VERIFY_NONE, http.verify_mode)
159+
assert_equal(http.use_ssl, true)
160+
assert_equal(http.verify_mode, OpenSSL::SSL::VERIFY_PEER)
161161
end
162162

163163
def test__

0 commit comments

Comments
 (0)