Skip to content

Commit aee9956

Browse files
committed
Fix assert_equal variables
1 parent 2d0d8ac commit aee9956

File tree

1 file changed

+15
-15
lines changed

1 file changed

+15
-15
lines changed

test/test_ruby_http_client.rb

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -50,49 +50,49 @@ def test_update_headers
5050
def test_build_request_headers
5151
request = {}
5252
request = @client.build_request_headers(request)
53-
assert_equal(@client.request_headers, request)
53+
assert_equal(request, @client.request_headers)
5454
end
5555

5656
def test_add_version
5757
url = ''
5858
@client.add_version(url)
59-
assert_equal(url, "/#{@version}")
59+
assert_equal("/#{@version}", url)
6060
end
6161

6262
def test_build_query_params
6363
url = ''
6464
query_params = { 'limit' => 100, 'offset' => 0 }
6565
url = @client.build_query_params(url, query_params)
66-
assert_equal(url, '?limit=100&offset=0')
66+
assert_equal('?limit=100&offset=0', url)
6767
end
6868

6969
def test_build_url
7070
url1 = @client.my.path.to.the.endpoint
7171
params = { 'limit' => 100, 'offset' => 0 }
7272
url = URI.parse(@host + '/' + @version +
7373
'/my/path/to/the/endpoint?limit=100&offset=0')
74-
assert_equal(url1.build_url(query_params: params), url)
74+
assert_equal(url, url1.build_url(query_params: params))
7575

7676
url1 = url1.one_more
7777
params = { 'limit' => 100, 'offset' => 0 }
7878
url = URI.parse(@host + '/' + @version +
7979
'/my/path/to/the/endpoint/one_more?limit=100&offset=0')
80-
assert_equal(url1.build_url(query_params: params), url)
80+
assert_equal(url, url1.build_url(query_params: params))
8181

8282
url2 = @client.my.path._('to').the.endpoint
8383
params = { 'limit' => 100, 'offset' => 0 }
8484
url = URI.parse(@host + '/' + @version +
8585
'/my/path/to/the/endpoint?limit=100&offset=0')
86-
assert_equal(url2.build_url(query_params: params), url)
86+
assert_equal(url, url2.build_url(query_params: params))
8787
end
8888

8989
def test_build_request
9090
name = 'get'
9191
args = nil
9292
response = @client.build_request(name, args)
93-
assert_equal(response.status_code, 200)
94-
assert_equal(response.body, 'message' => 'success')
95-
assert_equal(response.headers, 'headers' => 'test')
93+
assert_equal(200, response.status_code)
94+
assert_equal({'message' => 'success'}, response.body)
95+
assert_equal({'headers' => 'test'}, response.headers)
9696
end
9797

9898
def test_build_request_post_empty_content_type
@@ -156,19 +156,19 @@ def add_ssl
156156
uri = URI.parse('https://localhost:4010')
157157
http = Net::HTTP.new(uri.host, uri.port)
158158
http = @client.add_ssl(http)
159-
assert_equal(http.use_ssl, true)
160-
assert_equal(http.verify_mode, OpenSSL::SSL::VERIFY_NONE)
159+
assert_equal(true, http.use_ssl)
160+
assert_equal(OpenSSL::SSL::VERIFY_NONE, http.verify_mode)
161161
end
162162

163163
def test__
164164
url1 = @client._('test')
165-
assert_equal(url1.url_path, ['test'])
165+
assert_equal(['test'], url1.url_path)
166166
end
167167

168168
def test_method_missing
169169
response = @client.get
170-
assert_equal(response.status_code, 200)
171-
assert_equal(response.body, 'message' => 'success')
172-
assert_equal(response.headers, 'headers' => 'test')
170+
assert_equal(200, response.status_code)
171+
assert_equal({'message' => 'success'}, response.body)
172+
assert_equal({'headers' => 'test'}, response.headers)
173173
end
174174
end

0 commit comments

Comments
 (0)