Add test for request

Author: awwa

lib/ruby_http_client.rb

@@ -19,7 +19,7 @@ def initialize(response)
 
   # A simple REST client.
   class Client
-    attr_reader :host, :request_headers, :url_path
+    attr_reader :host, :request_headers, :url_path, :request, :http
     # * *Args*    :
     #   - +host+ -> Base URL for the api. (e.g. https://api.sendgrid.com)
     #   - +request_headers+ -> A hash of the headers you want applied on
@@ -142,23 +142,21 @@ def build_url(query_params: nil)
     def build_request(name, args)
       build_args(args) if args
       uri = build_url(query_params: @query_params)
-      http = Net::HTTP.new(uri.host, uri.port)
-      http = add_ssl(http)
+      @http = add_ssl(Net::HTTP.new(uri.host, uri.port))
       net_http = Kernel.const_get('Net::HTTP::' + name.to_s.capitalize)
-      request = net_http.new(uri.request_uri)
-      request = build_request_headers(request)
+      @request = build_request_headers(net_http.new(uri.request_uri))
       if (@request_body &&
           (!@request_headers.has_key?('Content-Type') ||
            @request_headers['Content-Type'] == 'application/json')
       )
-        request.body = @request_body.to_json
-        request['Content-Type'] = 'application/json'
+        @request.body = @request_body.to_json
+        @request['Content-Type'] = 'application/json'
       elsif !@request_body and (name.to_s == "post")
-        request['Content-Type'] = ''
+        @request['Content-Type'] = ''
       else
-        request.body = @request_body
+        @request.body = @request_body
       end
-      make_request(http, request)
+      make_request(@http, @request)
     end
 
     # Make the API call and return the response. This is separated into

test/test_ruby_http_client.rb

@@ -1,4 +1,4 @@
-require_relative '../lib/ruby_http_client'
+require 'ruby_http_client'
 require 'minitest/autorun'
 
 class MockResponse
@@ -95,6 +95,63 @@ def test_build_request
     assert_equal(response.headers, 'headers' => 'test')
   end
 
+  def test_build_request_post_empty_content_type
+    headers = {
+    }
+    client = MockRequest.new(
+      host: 'https://localhost',
+      request_headers: headers,
+      version: 'v3'
+    )
+    args = [{'request_body' => {"hogekey" => "hogevalue"}}]
+    client.build_request('post', args)
+    assert_equal('application/json', client.request['Content-Type'])
+    assert_equal('{"hogekey":"hogevalue"}', client.request.body)
+  end
+
+  def test_build_request_get_application_json
+    headers = {
+      'Content-Type' => 'application/json'
+    }
+    client = MockRequest.new(
+      host: 'https://localhost',
+      request_headers: headers,
+      version: 'v3'
+    )
+    client.build_request('get', nil)
+    assert_equal('application/json', client.request['Content-Type'])
+    assert_equal(nil, client.request.body)
+  end
+
+  def test_build_request_post_empty_body
+    headers = {
+      'Content-Type' => 'application/json'
+    }
+    client = MockRequest.new(
+      host: 'https://localhost',
+      request_headers: headers,
+      version: 'v3'
+    )
+    client.build_request('post', nil)
+    assert_equal('', client.request['Content-Type'])
+    assert_equal(nil, client.request.body)
+  end
+
+  def test_build_request_post_multipart
+    headers = {
+      'Content-Type' => 'multipart/form-data; boundary=xYzZY'
+    }
+    client = MockRequest.new(
+      host: 'https://localhost',
+      request_headers: headers,
+    )
+    name = 'post'
+    args = [{'request_body' => 'hogebody'}]
+    client.build_request(name, args)
+    assert_equal('multipart/form-data; boundary=xYzZY', client.request['Content-Type'])
+    assert_equal('hogebody', client.request.body)
+  end
+
   def add_ssl
     uri = URI.parse('https://localhost:4010')
     http = Net::HTTP.new(uri.host, uri.port)