[cpp] fix Semgrep pattern parsing for class/struct/enum bodies and operator overloads#2
Draft
brandonspark wants to merge 1 commit into
Draft
[cpp] fix Semgrep pattern parsing for class/struct/enum bodies and operator overloads#2brandonspark wants to merge 1 commit into
brandonspark wants to merge 1 commit into
Conversation
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Generated release artifacts from semgrep/ocaml-tree-sitter-semgrep#581.
Augments the C++ grammar so canonical Semgrep patterns parse cleanly:
...and$Xinside class/struct bodies (via_field_declaration_list_item) and enum bodies (via a wholesale override ofenumerator_list).operator $OPas an operator name (via aprevious-style augmentation ofoperator_name).The
semgrep_metavartoken gets a precedence bump so the lexer prefers it overidentifier(whose regex also accepts a leading$) when both are valid at a position; this lets a bare$Xparse as a metavariable inside enum/struct bodies instead of as a malformed declaration or enumerator.Upstream change: semgrep/ocaml-tree-sitter-semgrep#581
Test plan
./release --branch fix/cpp-pattern-augmentation cppfrom the upstream branch.Generated with Claude Code