Fix templates screen loading failure when vault references deleted access key#3404
Draft
Fix templates screen loading failure when vault references deleted access key#3404
Conversation
- Modified FillTemplateVault to gracefully handle missing access keys - Added error checking for ErrNotFound and log warning instead of failing - Added test case to verify templates load correctly with missing vault keys - Prevents entire template list from failing when one vault references deleted key Co-authored-by: fiftin <914224+fiftin@users.noreply.github.com>
- Document the function's behavior when vault keys are missing - Clarify that Vault field remains nil when key is not found - Explain error handling and logging approach Co-authored-by: fiftin <914224+fiftin@users.noreply.github.com>
Co-authored-by: fiftin <914224+fiftin@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix templates screen getting stuck in loading state
Fix templates screen loading failure when vault references deleted access key
Nov 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a template vault references a deleted access key,
GetTemplatesfails with 404, causing the frontend to hang in infinite loading state. Users encounter this after deleting vault passwords that templates still reference.Changes
db/TemplateVault.go: ModifiedFillTemplateVaultto catchErrNotFoundwhen fetching missing access keysnilvault instead of propagating errordb/bolt/template_vault_test.go: AddedTestGetTemplateVaults_WithMissingAccessKeyto verify templates load with orphaned vault referencesBehavior
Before:
After:
Templates now load successfully even when vault keys have been deleted, with
templateVault.Vaultremainingnilfor missing keys.Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.