feat: add pdf.less for better export with dw2pdf#156
Closed
micgro42 wants to merge 3 commits intoselfthinker:masterfrom
cosmocode:addPdfDotLess
Closed
feat: add pdf.less for better export with dw2pdf#156micgro42 wants to merge 3 commits intoselfthinker:masterfrom cosmocode:addPdfDotLess
micgro42 wants to merge 3 commits intoselfthinker:masterfrom
cosmocode:addPdfDotLess
Conversation
dw2pdf uses the print.css if there is no pdf.css available. It also allows the usage of the style.css for configured plugins. However wrap's print.css removes the left margin from note boxes and causes the text to be displayed above the icon in the resulting pdf. Adding a pdf.less fixes that problem and allows for feature changes affecting pdf only.
Owner
|
I finally had a look at this and am nearly happy to merge. I would make two changes:
I would also add some comments so it matches the commenting style of the other CSS files and adds information on how and when the file is used and that it's usually used together with style.css. But I can do that in a separate commit. Slightly related, what do you think of #130? |
Pdf is often just a step in between to printing and as such often used for archiving content. Hence content which should only be displayed in print should also be displayed in pdf. This is also consistent with hiding item that are marked as no-print.
Contributor
Author
|
Implemented your comments. Since we now should have working |
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dw2pdf uses the print.css if there is no pdf.css available. It also allows the usage of the style.css for configured plugins. However, wrap's print.css removes the left margin from note boxes and causes the text to be displayed above the icon in the resulting pdf.
Adding a pdf.less fixes that problem and allows for feature changes affecting pdf only.
To work its magic, this pull request depends on the bugfix in splitbrain/dokuwiki-plugin-dw2pdf#325 .